Skip to content

5.13.2 #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 27, 2024
Merged

5.13.2 #1719

merged 14 commits into from
Aug 27, 2024
+149 −38

Conversation

silasary
Copy link
Member

July Update?

silasary and others added 6 commits June 28, 2024 23:11
@silasary
Fix typo in pyproject.toml (#1711)
2ec798b
@AstreaTSS
fix: fallback to list if entitlements is not provided (#1715)
49ecdf9
@silasary
feat: Add audioop-lts for python 3.13+ (#1713)
2a896b7 
Fixes #1685
@sondevra
fix: command lookup error when scope is cached (#1716)
42df28b 
* fix: command lookup error when scope is cached

Fixed lookup to use .get() on the dictionary to prevent large log of error in the circumstance of a cache command showing on a changed scope

Signed-off-by: Sondra <125593620+sondevra@users.noreply.github.com>

* Update context.py

Signed-off-by: Sondra <125593620+sondevra@users.noreply.github.com>

---------

Signed-off-by: Sondra <125593620+sondevra@users.noreply.github.com>
@AstreaTSS
fix/test: ensure polls are being correctly processed (#1714)
fcd8efe 
* fix: use answer_id from data, not options

* fix: correctly deserialize question for polls

* ci: add tests for polls

* test: make poll dict test more resilient
@mifuyutsuki
fix: change CronTrigger next_fire start time (#1718)
bdc52f1 
Replaces the croniter start_time in CronTrigger from `datetime.now()` to `self.last_call_time.astimezone()` to fix a bug causing possible multiple firing.

Fixes #1717
@AstreaTSS
Copy link
Member

👋. I'm going to try to get this moving along.

Current fix PRs: #1724, #1725, #1727, #1728, #1729, #1730 (technically a feat PR, but the lack of the new feature causes a lot of annoying errors so why not)

I'll be reviewing what I can today, although some of these are my PRs and so will require another person to help out.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.51%. Comparing base (1a7de56) to head (38f3162).
Report is 81 commits behind head on stable.

Files Patch % Lines
interactions/models/internal/context.py 33.33% 2 Missing ⚠️
interactions/models/discord/message.py 0.00% 1 Missing ⚠️
interactions/models/internal/tasks/triggers.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           stable    #1719      +/-   ##
==========================================
+ Coverage   45.95%   46.51%   +0.55%     
==========================================
  Files         144      149       +5     
  Lines       15492    16176     +684     
==========================================
+ Hits         7120     7524     +404     
- Misses       8372     8652     +280

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Lacosst0 and others added 2 commits August 12, 2024 13:33
@Lacosst0
fix: make _on_raw_message_poll_vote events use correct data (#1725)
ecf7b9e
@SirTurlock
fix: use int nonce for heartbeat instead of float for VoiceGateway (#…
33f8bdf 
…1727)

Fixes #1726
VoiceGateway no longer accepts a string or a float in the heartbeat nonce and instead immediately disconnects the client with code 4020.
Fixed send_heartbeat to use an uint64 instead of a float for the nonce.
@AstreaTSS
Copy link
Member

All not-me PRs have been merged. Only #1724 and #1728 remain.

LawMixer
LawMixer approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@LawMixer LawMixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to review these changes - they work for me on Python3.10 and Python3.11;

@silasary silasary merged commit 369a291 into stable Aug 27, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstreaTSS AstreaTSS AstreaTSS approved these changes

@LawMixer LawMixer LawMixer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@silasary @AstreaTSS @codecov-commenter @LawMixer @sondevra @mifuyutsuki @retr0-init @Lacosst0 @SirTurlock